Skip to content

Conversation

@dsseng
Copy link
Member

@dsseng dsseng commented Oct 30, 2025

  • Add d_* PSI derivative values to the trigger expression context
  • Only trigger OOM action while PSI is rising
  • Make OOM test fail if controller kills a cgroup without stress-ng

Fixes #12077

@github-project-automation github-project-automation bot moved this to To Do in Planning Oct 30, 2025
@talos-bot talos-bot moved this from To Do to In Review in Planning Oct 30, 2025
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@github-project-automation github-project-automation bot moved this from In Review to Approved in Planning Oct 30, 2025
@dsseng dsseng force-pushed the fix-oom-false-pos branch from 79bffbc to 6dcb6a6 Compare October 30, 2025 17:25
@dsseng dsseng added the integration/qemu-race QEMU w/ race detector label Oct 30, 2025
@dsseng dsseng force-pushed the fix-oom-false-pos branch from 6dcb6a6 to 5974db3 Compare October 30, 2025 21:08
@dsseng dsseng force-pushed the fix-oom-false-pos branch 4 times, most recently from 828fc72 to 49c5e9f Compare November 3, 2025 08:40
@smira
Copy link
Member

smira commented Nov 5, 2025

I don't know if we should relax our assertions a bit by allowing non-stressng kills?

@dsseng dsseng force-pushed the fix-oom-false-pos branch 2 times, most recently from 99320a4 to efe4249 Compare November 6, 2025 13:12
@dsseng dsseng removed the integration/qemu-race QEMU w/ race detector label Nov 6, 2025
@dsseng dsseng force-pushed the fix-oom-false-pos branch from efe4249 to bdd5a66 Compare November 6, 2025 17:50
…ositives

- Add d_* PSI derivative values to the trigger expression context
- Only trigger OOM action while PSI is rising
- Make OOM test fail if controller kills a cgroup without stress-ng
- Wait for stress-mem to terminate before proceeding with the next tests
- Skip OOM test when running with race detector

Signed-off-by: Dmitrii Sharshakov <[email protected]>
@dsseng dsseng force-pushed the fix-oom-false-pos branch from bdd5a66 to c93a9c6 Compare November 6, 2025 18:52
@dsseng
Copy link
Member Author

dsseng commented Nov 6, 2025

/m

@talos-bot talos-bot merged commit c93a9c6 into siderolabs:main Nov 6, 2025
59 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in Planning Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

improve cooldown of OOM trigger

4 participants